Bump libwacom 2.18#25
Conversation
Multiple Fedora 44 packages build against libwacom 2.18.
fedora 41 and 42 not tested against libwacom 2.18 https://packages.fedoraproject.org/pkgs/libwacom/libwacom/
Debian Sid is built against libwacom 2.18.0: https://packages.debian.org/sid/libwacom-common
|
This also ties into linux-surface/linux-surface#2094 I believe. |
|
Thanks! I think this would also resolve linux-surface/linux-surface#2076 (due to just the version bump) I am not a maintainer, but I notice that you replaced a lot of the build process, and bumped unrelated action versions. Was this explicitly required? My experience is that maintainers are less likely to review PRs that don't look very clean, and that make lots of extraneous changes. Is there a more minimal version of this PR that you'd like to see upstreamed? I'm curious if you could easily add fedora-44 without replacing fedora-42 in the build scripts (which I presume would remove support for federo-42)? Regardless, thanks for making the PR! |
|
Hi patcon, many thanks, hope its useful. I made the PR providing the maintainers with the option to edit PR before merge so that should provide them with one means. In particular I bumped the action versions as I can see that equivalent updates had already been merged into the other CI workflows, so presumably it needed doing. I see it as in fact hard to defend adding new code for new steps calling on sun-setting action versions. At which point not updating the other action versions I saw as a messy job half done that would leave a single single unit of code in an (almost invalid) Frankenstein's monster mess of mixed states. I was betting that actually made the PR easier to accept as ready. If when a maintainer looks at the PR, any feedback on how I can better help in the future, if for example its in part or exactly as you highlight, would be greatly appreciated. If there was a test branch to do the PR against I might have done exactly as you say, but I saw the sum of all these commits as being necessary in order for them to be commendable to master production. I took a guess. Anyway, as I say my overriding reasoning though is just that I'm assuming it will be easy for the maintainers to cherry pick to exclude any commits they don't want. |
These changes bump the libwacom version to 2.18 and add support for Fedora 44
NB: the change logs have 'not' been updated though as this appears to be something that should have a maintainer/approver's name against it. Bottom of /pkg/fedora/libwacom-surface.spec & /pkg/deb/debian/changelog
https://github.com/linuxwacom/libwacom/releases/tag/libwacom-2.18.0
The only new feature that appears to be functional and not hardware specific is 'Add libwacom_stylus_is_generic() to detect generic styli' . This might have some value to leverage in the future however, having built for Fedora 44 the commits here test good RE the build steps.
I have not tested the 'Publish Release' and 'Update...' jobs in the workflow because they are specific to the repo.
I have tested an altered version of the build jobs with signing disabled. https://github.com/orthogonaleety/libwacom-surface/actions/runs/26401846415
This tests good as a fix to the problem I had #2148